This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Display domain docstrings in the search results #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dojutsu-user
added
the
PR: work in progress
| @@ -340,7 +312,7 @@ const generateSingleResult = (resultData, projectName) => { | |||
| </h2> \ | |||
| </a>'; | |||
|
|
|||
| let page_link = `${resultData.link}${DOCUMENTATION_OPTIONS.FILE_SUFFIX}`; | |||
| let page_link = READTHEDOCS_DATA.canonical_url + resultData.full_path; | |||
There was a problem hiding this comment.
Any reason for this change? I don't know if we should be forcibly changing domains in search results, it feels less than ideal.
There was a problem hiding this comment.
No... I forgot to update this PR.
This change was done when I got confused with serving static files from nginx
I have undoed this change.
ericholscher
approved these changes
Aug 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR in readthedocs.org -- readthedocs/readthedocs.org#5979