Link To Search UI #25
Conversation
|
I wrote wrong commit msg. |
dojutsu-user
added
the
PR: work in progress
|
@dojutsu-user this is now conflicting with the recent merge. |
dojutsu-user
removed
the
PR: work in progress
| let path = window.location.pathname; | ||
| let url_params = $.getQueryParameters(); | ||
|
|
||
| if (_is_string(SEARCH_QUERY)) { |
There was a problem hiding this comment.
This could probably use a comment. When will it not be a string?
There was a problem hiding this comment.
This will always be a string. It will become false if SEARCH_QUERY becomes empty string.
_is_string func checks two things:
- The type of the data
- if the type is 'string', then it should be of length >= 1
| search_outer_wrapper.is_displayed() is True | ||
| ), 'search modal should displayed when the page loads' | ||
| assert ( | ||
| search_result_box.text == 'Error Occurred. Please try again.' |
There was a problem hiding this comment.
Why does this show an error?
There was a problem hiding this comment.
Because the ajax func is overwritten to return an error here - https://github.com/readthedocs/readthedocs-sphinx-search/pull/25/files#diff-42e9264de947b8999fda83bf2bacd290R610
There was a problem hiding this comment.
Is there a reason we're testing for an error when we're just trying to see if it shows up?
There was a problem hiding this comment.
I guess we have to test for something :)
There was a problem hiding this comment.
There's no particual reason -- I just wanted to test that modal shouldn't be empty after page is loaded and modal is shown.
It also proves that a jquery ajax request was there.
Ohh.. I think we should preserve that also. |
|
@ericholscher |
No description provided.