Link to search modal #20
Conversation
dojutsu-user
added
Needed: documentation
dojutsu-user
added
PR: work in progress
dojutsu-user
removed
the
PR: work in progress
| urlToBeCopied += "?" + urlParam; | ||
| } | ||
|
|
||
| copyToClipBoard(urlToBeCopied); |
There was a problem hiding this comment.
I don't quite follow what this is doing. We should just update the browser's URL when the user types with the proper data, we don't need a custom way to copy a link.
There was a problem hiding this comment.
This is generating the url to the search ui and then copying it to the clipboard.
| vars[key] = value; | ||
| } | ||
| ); | ||
| return vars; |
There was a problem hiding this comment.
Is this really not in jQuery already? I feel like we're reinventing a lot of wheels.
There was a problem hiding this comment.
No.
I checked on the internet. There is no direct utility from the jquery or javascript to get the url parameters.
| textarea.select(); | ||
| document.execCommand("copy"); | ||
| document.body.removeChild(textarea); | ||
| }; |
There was a problem hiding this comment.
Same here, is this really not a standard thing?
There was a problem hiding this comment.
No.
here also -- no utility of jquery or javascript is there which dirctly copies the text.
I have some different thoughts here -- I think it would be better to give user the choice to share the link to his/her search. Just like the sections in the docs. |
dojutsu-user
added
the
PR: work in progress
|
Closing in favor of #25 |
Demo:
If the url params contains
rtd_search, then the modal will open and search for its value.The demo is not according to the PR #19
But I tried it with #19 and it worked great.