Skip to content

Fix typo on PYPY version #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2019
Merged

Fix typo on PYPY version #96

merged 1 commit into from
Mar 4, 2019

Conversation

humitos
Copy link
Member

@humitos humitos commented Feb 27, 2019

Just a typo

@bebehei
Copy link
Contributor

bebehei commented Feb 27, 2019

docker build . still failing though. What are your testing methods!?

@humitos
Copy link
Member Author

humitos commented Feb 27, 2019

@bebehei testing a docker image of ~7gb is hard if you don't have a good internet connection (and disk space!). Feel free to fix it properly or, considering that you already ran that command, share the feedback to know where it breaks. Thanks!

@bebehei
Copy link
Contributor

bebehei commented Mar 1, 2019

@humitos I agree with you. While writing my PRs, my only system available built the image in a full hour. Testing it was a PITA. I have to run docker image prune regularly. Your own situation might be much worse.

But this is not how bad one's situation is. This is about enforcing minimal functionality in a project.

There's no problem, if things go south in a PR. I for myself pushed to PRs this week, which also didn't even compile. I made the same mistakes this week. Sometimes I even push untested to a PR on purpose, if the project is too big. So I push to my PR until CI gives a green checkmark.

But what freaks me out: There's a PR, which gets approved and merged onto the master branch while nobody has ever even checked it out and attempted to build it. It didn't build at all.

And no, in times where techniques to avoid this are broadly available, the excuse "I haven't got a beefy machine" isn't valid.

Feel free to fix it properly or, considering that you already ran that command, share the feedback to know where it breaks. Thanks!

I expected you did that by yourself. I'd definitely would have shared the feedback. Now that I'm knowing the circumstances, I would have reacted otherwise, sorry.

I propose you merge #96 (which also reverts your faulty commit). And then rework your PR #93 until it builds successfully. Just do a force push and you won't annoy anyone with push emails. So at the end of the day, everything will turn out fine.

If you care about the "wasted" build time on Travis: You're maintaining the basis of one of the biggest open source projects. 20 Minutes build time shouldn't matter in this case.

@humitos humitos merged commit cb0eb7e into master Mar 4, 2019
@humitos humitos deleted the humitos/fix-typo branch March 4, 2019 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants