-
Notifications
You must be signed in to change notification settings - Fork 71
Install pypy3.5-7.0.0 and make it available #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm curious how we execute commands here? We have a |
Yes! Same flow as usual should work:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me. Sad to make things larger. I do wonder if we should start splitting up docker images based on Python version, but that just creates a different problem and more total space :/
I'm merging this one. We will need to adapt our YAML code to be able to allow something like |
@@ -150,10 +152,12 @@ ENV PATH /home/docs/.pyenv/shims:$PATH:/home/docs/.pyenv/bin | |||
RUN pyenv install $PYTHON_VERSION_27 && \ | |||
pyenv install $PYTHON_VERSION_37 && \ | |||
pyenv install $PYTHON_VERSION_36 && \ | |||
pyenv install $PY_VERSION_35 && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least this typo broke the current master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Fixed at #96
I think it's a good idea to start having a pypy version in our docker images.
David found that this could speed up many builds. So, it could be a suggested way for "My builds are taking too much time" in the FAQ section once this is tested a little more.
Reference: readthedocs/readthedocs.org#3870