Skip to content

Install pypy3.5-7.0.0 and make it available #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2019

Conversation

humitos
Copy link
Member

@humitos humitos commented Feb 14, 2019

I think it's a good idea to start having a pypy version in our docker images.

David found that this could speed up many builds. So, it could be a suggested way for "My builds are taking too much time" in the FAQ section once this is tested a little more.

Reference: readthedocs/readthedocs.org#3870

@stsewd
Copy link
Member

stsewd commented Feb 14, 2019

I'm curious how we execute commands here? We have a python binary too?

@humitos
Copy link
Member Author

humitos commented Feb 14, 2019

Yes! Same flow as usual should work:

~ ⌚ 23:47:44
$ pyenv shell pypy3.5-7.0.0 

~ ⌚ 23:47:52
$ python
Python 3.5.3 (928a4f70d3de7d17449456946154c5da6e600162, Feb 09 2019, 11:50:43)
[PyPy 7.0.0 with GCC 8.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>>> 

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Sad to make things larger. I do wonder if we should start splitting up docker images based on Python version, but that just creates a different problem and more total space :/

@humitos
Copy link
Member Author

humitos commented Feb 26, 2019

I'm merging this one.

We will need to adapt our YAML code to be able to allow something like pypy3.5-7.0.0 or pypy3.5 or similar.

@humitos humitos merged commit fc0ad63 into master Feb 26, 2019
@humitos humitos deleted the humitos/install-pypy35 branch February 26, 2019 08:06
@@ -150,10 +152,12 @@ ENV PATH /home/docs/.pyenv/shims:$PATH:/home/docs/.pyenv/bin
RUN pyenv install $PYTHON_VERSION_27 && \
pyenv install $PYTHON_VERSION_37 && \
pyenv install $PYTHON_VERSION_36 && \
pyenv install $PY_VERSION_35 && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least this typo broke the current master.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fixed at #96

@bebehei bebehei mentioned this pull request Mar 1, 2019
@humitos humitos mentioned this pull request Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants