-
Notifications
You must be signed in to change notification settings - Fork 534
Wip add modulename √ #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The head ref may contain hidden characters: "wip-add-modulename-\u221A"
Wip add modulename √ #412
Changes from 3 commits
a4c2288
162e6b5
5706b82
f111e0f
8987429
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,3 +40,4 @@ egetman | Evgeniy Getman, [email protected] | |
patriknw | Patrik Nordwall, [email protected], Lightbend Inc | ||
angelsanz | Ángel Sanz, [email protected] | ||
shenghaiyang | 盛海洋, [email protected] | ||
kiiadi | Kyle Thomson, [email protected], Amazon.com |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,7 @@ | ||
description = "reactive-streams" | ||
description = "reactive-streams" | ||
|
||
jar { | ||
manifest { | ||
attributes('Automatic-Module-Name': 'org.reactivestreams') | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,8 +6,21 @@ dependencies { | |
testCompile project(':reactive-streams-tck') | ||
testCompile group: 'org.testng', name: 'testng', version: '5.14.10' | ||
} | ||
|
||
jar { | ||
manifest { | ||
attributes('Automatic-Module-Name': 'org.reactivestreams.flowadapters') | ||
} | ||
} | ||
|
||
test.useTestNG() | ||
|
||
jar { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Again, but with different name? |
||
manifest { | ||
attributes('Automatic-Module-Name': 'org.reactivestreams.flowbridge') | ||
} | ||
} | ||
|
||
javadoc { | ||
options.links("http://download.java.net/java/jdk9/docs/api") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This gives 404. The proper link is |
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears twice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akarnokd Nice catch, I've fixed that now :)