Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktorklang
force-pushed
the
wip-add-modulename-√
branch
from
58d32da to
5706b82
Compare
akarnokd
reviewed
Nov 22, 2017
| @@ -6,8 +6,21 @@ dependencies { | |||
| testCompile project(':reactive-streams-tck') | |||
| testCompile group: 'org.testng', name: 'testng', version: '5.14.10' | |||
| } | |||
|
|
|||
| jar { | |||
There was a problem hiding this comment.
@akarnokd Nice catch, I've fixed that now :)
|
@kiiadi @reactive-streams/contributors Everyone OK with this? |
akarnokd
reviewed
Nov 22, 2017
flow-adapters/build.gradle
Outdated
| test.useTestNG() | ||
|
|
||
| jar { |
There was a problem hiding this comment.
Again, but with different name?
akarnokd
reviewed
Nov 22, 2017
flow-adapters/build.gradle
Outdated
| attributes('Automatic-Module-Name': 'org.reactivestreams.flowbridge') | ||
| } | ||
| } | ||
|
|
||
| javadoc { | ||
| options.links("http://download.java.net/java/jdk9/docs/api") |
There was a problem hiding this comment.
This gives 404. The proper link is https://docs.oracle.com/javase/9/docs/api/
akarnokd
approved these changes
Nov 22, 2017
Closed
|
Checked the names, this looks good to go 👍 |
ktoso
approved these changes
Nov 22, 2017
|
Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including @kiiadi's commit here.