Fix 'foreach' comment in AsyncSubscriber and rename SyncSybscriber.foreach to whenNext

CopyrightWaivers.txt

@@ -30,3 +30,4 @@ ldaley         | Luke Daley, [email protected], Gradleware Inc.
 colinrgodsey   | Colin Godsey, [email protected], MediaMath Inc.
 davidmoten     | Dave Moten, [email protected]
 briantopping   | Brian Topping, [email protected], Mauswerks LLC
+rstoyanchev    | Rossen Stoyanchev, [email protected], Pivotal

examples/src/main/java/org/reactivestreams/example/unicast/AsyncSubscriber.java

@@ -50,7 +50,7 @@ protected AsyncSubscriber(Executor executor) {
   // herefor we also need to cancel our `Subscription`.
   private final void done() {
     //On this line we could add a guard against `!done`, but since rule 3.7 says that `Subscription.cancel()` is idempotent, we don't need to.
-    done = true; // If we `foreach` throws an exception, let's consider ourselves done (not accepting more elements)
+    done = true; // If `whenNext` throws an exception, let's consider ourselves done (not accepting more elements)
     if (subscription != null) { // If we are bailing out before we got a `Subscription` there's little need for cancelling it.
       try {
         subscription.cancel(); // Cancel the subscription

examples/src/main/java/org/reactivestreams/example/unicast/SyncSubscriber.java

@@ -49,7 +49,7 @@ public abstract class SyncSubscriber<T> implements Subscriber<T> {
 
       if (!done) { // If we aren't already done
         try {
-          if (foreach(element)) {
+          if (whenNext(element)) {
             try {
               subscription.request(1); // Our Subscriber is unbuffered and modest, it requests one element at a time
             } catch (final Throwable t) {
@@ -76,7 +76,7 @@ public abstract class SyncSubscriber<T> implements Subscriber<T> {
   // herefor we also need to cancel our `Subscription`.
   private void done() {
     //On this line we could add a guard against `!done`, but since rule 3.7 says that `Subscription.cancel()` is idempotent, we don't need to.
-    done = true; // If we `foreach` throws an exception, let's consider ourselves done (not accepting more elements)
+    done = true; // If we `whenNext` throws an exception, let's consider ourselves done (not accepting more elements)
     try {
       subscription.cancel(); // Cancel the subscription
     } catch(final Throwable t) {
@@ -87,7 +87,7 @@ private void done() {
 
   // This method is left as an exercise to the reader/extension point
   // Returns whether more elements are desired or not, and if no more elements are desired
-  protected abstract boolean foreach(final T element);
+  protected abstract boolean whenNext(final T element);
 
   @Override public void onError(final Throwable t) {
     if (subscription == null) { // Technically this check is not needed, since we are expecting Publishers to conform to the spec

examples/src/test/java/org/reactivestreams/example/unicast/SyncSubscriberTest.java

@@ -24,7 +24,7 @@ public SyncSubscriberTest() {
   @Override public Subscriber<Integer> createSubscriber() {
     return new SyncSubscriber<Integer>() {
       private long acc;
-      @Override protected boolean foreach(final Integer element) {
+      @Override protected boolean whenNext(final Integer element) {
         acc += element;
         return true;
       }

examples/src/test/java/org/reactivestreams/example/unicast/SyncSubscriberWhiteboxTest.java

@@ -62,7 +62,7 @@ public void onComplete() {
       }
 
       @Override
-      protected boolean foreach(Integer element) {
+      protected boolean whenNext(Integer element) {
         return true;
       }
     };

tck/src/test/java/org/reactivestreams/tck/support/SyncTriggeredDemandSubscriber.java

@@ -7,7 +7,7 @@
  * SyncTriggeredDemandSubscriber is an implementation of Reactive Streams `Subscriber`,
  * it runs synchronously (on the Publisher's thread) and requests demand triggered from
  * "the outside" using its `triggerDemand` method and from "the inside" using the return
- * value of its user-defined `foreach` method which is invoked to process each element.
+ * value of its user-defined `whenNext` method which is invoked to process each element.
  *
  * NOTE: The code below uses a lot of try-catches to show the reader where exceptions can be expected, and where they are forbidden.
  */
@@ -85,7 +85,7 @@ else if (need == 0) {}
   // herefor we also need to cancel our `Subscription`.
   private void done() {
     //On this line we could add a guard against `!done`, but since rule 3.7 says that `Subscription.cancel()` is idempotent, we don't need to.
-    done = true; // If we `foreach` throws an exception, let's consider ourselves done (not accepting more elements)
+    done = true; // If we `whenNext` throws an exception, let's consider ourselves done (not accepting more elements)
     try {
       subscription.cancel(); // Cancel the subscription
     } catch(final Throwable t) {