Fix 'foreach' comment in AsyncSubscriber and rename SyncSybscriber.foreach to whenNext #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rstoyanchev Thanks for the correction/touch-up! Would you mind adding yourself to the copyright-waivers in this commit and push again so that it can be merged? Thanks, √ |
|
Sure thing, done. |
|
LGTM from my point of view as well, thanks :) |
|
👍 |
|
Thank you @rstoyanchev! |
viktorklang
added a commit
that referenced
this pull request
Sep 8, 2015
Fix 'foreach' comment in AsyncSubscriber and rename SyncSybscriber.foreach to whenNext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AsyncSubscriber had a comment referring to
foreachwhich is a method that exists in SyncSubscriber while in AsyncSubscriber it is calledwhenNext.This PR also renames
foreachin SyncSubscriber towhenNext. When I first looked at SyncSubscriber I had the impression there was a loop. It doesn't make sense I know since I did look atforeach. Nevertheless it was only when I debugged that I realized that just above isif (!done)and notwhile (!done).Feel free to ignore this if you had some strong reason for the naming.