Skip to content

Release 1.0.0.RC1 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cconstantin opened this issue Jun 22, 2016 · 23 comments
Closed

Release 1.0.0.RC1 #11

cconstantin opened this issue Jun 22, 2016 · 23 comments

Comments

@cconstantin
Copy link
Contributor

No description provided.

@marcpiechura
Copy link
Contributor

marcpiechura commented Jun 24, 2016

Things that need to be done before we can release RC1:

@marcpiechura
Copy link
Contributor

@viktorklang are you providing the build server and integration?

@viktorklang
Copy link
Contributor

@Silv3rcircl3 If someone gives me a step-by-step guide to set up a free-of-charge CI then I can help out. We have a reactive-streams-ci GH account which could be used.

@marcpiechura
Copy link
Contributor

@viktorklang I tried to run the build script several times on Appveyor but I'm unable to produce a reliable build, due to the low resources that these free build servers offer we aren't able to produce some race conditions that are needed for some of the async specs.
I would suggest that we use the Akka.net build server, Aaron already said that he would provide the setup and only needs a OAuth token for the status API.

@marcpiechura
Copy link
Contributor

@viktorklang I talked with Aaron and he proposed that we could use the build bot to post comments on a PR with the build result. With this approach we wouldn't need the OAuth token anymore.
Would that meet your requirements?

@alexvaluyskiy
Copy link
Contributor

What about NetStandard support?

@viktorklang
Copy link
Contributor

@Silv3rcircl3 You mean running a CI completely standalone without a webhook?

@marcpiechura
Copy link
Contributor

@viktorklang exactly, we can configure our build server to poll for new PR's and if he detects one he will build it and post a normal github comment on that PR with the build result. So probably no interaction from your side needed.

@viktorklang
Copy link
Contributor

Alright, let's start there, and if we find a more integrated solution, give
me a head's up.

On Tue, Jun 28, 2016 at 1:34 PM, Marc Piechura [email protected]
wrote:

@viktorklang https://github.com/viktorklang exactly, we can configure
our build server to poll for new PR's and if he detects one he will build
it and post a normal github comment on that PR with the build result. So
probably no interaction from your side needed.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAAqdxlKXJCw5m3GTAs7Vl2gPJ-pFt4Kks5qQQbBgaJpZM4I77MS
.

Cheers,

@marcpiechura
Copy link
Contributor

@alexvaluyskiy haven't looked into it since we need to wait for NUnit anyway. But sure in the feature we should support NetStandard but maybe outside of the RC1 scope.

@alexvaluyskiy
Copy link
Contributor

alexvaluyskiy commented Jun 28, 2016

Nunit team have already had support for NetCore https://github.com/nunit/dotnet-test-nunit But it still an alpha

@marcpiechura
Copy link
Contributor

Nice and as I have seen the framework also already supports NetStandard. Do you want to work on this ?

@marcpiechura
Copy link
Contributor

@viktorklang from my PoV everything is ready for RC1, support for .Net Core can be added later without breaking compatibility with RC1.

@viktorklang
Copy link
Contributor

Hi @Silv3rcircl3, sounds good.

Make a PR with a single commit which updates the version number, adds release notes for that version etc, so we can make the release from that commit (and subsequently tag it with the appropriate tag name).

Anything else?

Cheers,

@marcpiechura
Copy link
Contributor

marcpiechura commented Jul 4, 2016

@viktorklang #17 needs to be merged before I can send the PR for RC1, otherwise the build would fail.

@viktorklang
Copy link
Contributor

@Silv3rcircl3 Merged!

Alright, I'm going on vacation now for a while, and while that might mean that I am more responsive here than the past month it is becoming clear that I am a bottleneck here.

We definitely need to augment the number of people who merge into this repository.
Do we have any volunteers? ;)

@marcpiechura
Copy link
Contributor

@viktorklang sure, count me in.

@cconstantin
Copy link
Contributor Author

@viktorklang count me in as well. Back from being away last week.

@viktorklang
Copy link
Contributor

Cool, I'll attempt to set things up correctly either tonight or tomorrow (depending on availability :))

@alexvaluyskiy
Copy link
Contributor

@Silv3rcircl3 it is not so important to move to NetStandard if we have PCL

@viktorklang
Copy link
Contributor

viktorklang commented Jul 5, 2016

Alright! Added @cconstantin and @Silv3rcircl3 to @reactive-streams/dotnet-contributors

@cconstantin
Copy link
Contributor Author

1.0.0-RC1 released

@ktoso
Copy link

ktoso commented Jul 5, 2016

Grats! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants