Skip to content

Please make sure the NuGet release supports the portable profile #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akarnokd opened this issue Jun 24, 2016 · 8 comments
Closed

Please make sure the NuGet release supports the portable profile #12

akarnokd opened this issue Jun 24, 2016 · 8 comments

Comments

@akarnokd
Copy link
Contributor

If not already ensured, please release the NuGet library so it can be consumed from a portable profile. (The assembly has to be compiled this way, unlike Java).

@cconstantin
Copy link
Contributor

@akarnokd I've targeted a portable profile in building the nuget package: https://github.com/alignedsolutions/reactive-streams-dotnet/commit/05ca8b1f49d0585e3c365a8940741ac7f109f5b2

Can you try to pack that locally and see if you can consume it from a portable profile?

@akarnokd
Copy link
Contributor Author

Not really, I know only how to import from NuGet via the VS GUI.

@cconstantin
Copy link
Contributor

@akarnokd you can easily create a local source and placed the generated package there: https://docs.nuget.org/create/hosting-your-own-nuget-feeds

@akarnokd
Copy link
Contributor Author

Sure, on it. A quick feedback: I had to manually enable generating the XML docs in the build properties; not sure if this property is saved to a project or not.

@akarnokd
Copy link
Contributor Author

Thanks, the local NuGet import works!

@cconstantin
Copy link
Contributor

Awesome, thanks for confirming @akarnokd . Also enabled the xml docs, thanks for pointing it out.

One more thing? Can you reference the package from a regular net45 profile?

@marcpiechura
Copy link
Contributor

PCL support is now included in #9 so this can be closed.

@viktorklang
Copy link
Contributor

closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants