fix data-* and aria-* attribute name conversion #911
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archmonger
previously approved these changes
Feb 3, 2023
Archmonger
reviewed
Feb 3, 2023
Archmonger
reviewed
Feb 4, 2023
| @@ -64,7 +64,7 @@ function normalizeAttribute([key, value]) { | |||
| key.startsWith("aria_") || | |||
| DASHED_HTML_ATTRS.includes(key) | |||
| ) { | |||
| normKey = key.replace("_", "-"); | |||
There was a problem hiding this comment.
An alternative to splitting the string is using replaceAll
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replaceAll
3 tasks
|
This PR seems moot, since aria attributes are going to be handled via dashes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stems from this comment.
Checklist
Please update this checklist as you complete each item:
changelog.rsthas been updated with any significant changes.