Skip to content

3.0.0a3 #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 21, 2023
Merged

3.0.0a3 #127

merged 11 commits into from
Feb 21, 2023

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Feb 4, 2023 •
edited
Loading

Description

  • Define use_scope return type as a dict to prevent clashes between django, django-stubs, and django-idom
  • Bump django-idom version
  • Prevent db_cleanup from causing startup failure on any DatabaseError, rather than just OperationalError(DatabaseError)
  • IDOM_DATABASE setting
  • IDOM_CACHE setting (instead of implicitly relying on `CACHE["idom"] to exist
  • Rename ComponentParams to ComponentSession (we're likely to reuse it for other stuff in the future)
  • Bump IDOM to latest pre-release
  • Use new VdomAttributes and key syntax in idom.html.*.

Checklist:

Please update this checklist as you complete each item:

  • Tests have been included for all bug fixes or added functionality.
  • The changelog has been updated with any significant changes, if necessary.
  • GitHub Issues which may be closed by this PR have been linked.

@Archmonger
Copy link
Contributor Author

@rmorshea I will until reactive-python/reactpy#911 is merged, and idom==1.0.0a4 is released before marking this as Ready for Review

@Archmonger Archmonger marked this pull request as ready for review February 21, 2023 12:07
@Archmonger Archmonger requested a review from rmorshea February 21, 2023 12:07
@Archmonger Archmonger merged commit 0e37352 into reactive-python:main Feb 21, 2023
@Archmonger Archmonger deleted the 3.0.0a3 branch February 21, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmorshea rmorshea rmorshea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Archmonger @rmorshea