Skip to content

Log on web module replacement instead of error #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 19, 2022
Merged

Log on web module replacement instead of error #586

merged 4 commits into from
Jan 19, 2022

Conversation

rmorshea
Copy link
Collaborator

Closes: #584

@rmorshea rmorshea mentioned this pull request Jan 14, 2022
Merged
@Archmonger
Copy link
Contributor

From a Django caching perspective, it would be ideal if it only replaced if the file contents are not identical.

@rmorshea
Copy link
Collaborator Author

That is what's implemented here. If the file contents differ and replace_existing is False you get an error instead of replacing the files.

Archmonger
Archmonger reviewed Jan 15, 2022
View reviewed changes
@rmorshea rmorshea force-pushed the better-modules branch 2 times, most recently from 054b5ca to 35a1b86 Compare January 19, 2022 02:31
@rmorshea rmorshea changed the title clean up web module from file and template logic Log on web module replacement instead of error Jan 19, 2022
@rmorshea rmorshea merged commit e4aa655 into main Jan 19, 2022
@rmorshea rmorshea deleted the better-modules branch January 19, 2022 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Archmonger Archmonger Archmonger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix unhandled case in module_from_template
2 participants
@rmorshea @Archmonger