Skip to content

Fix unhandled case in module_from_template #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rmorshea opened this issue Jan 14, 2022 · 0 comments · Fixed by #586
Closed

Fix unhandled case in module_from_template #584

rmorshea opened this issue Jan 14, 2022 · 0 comments · Fixed by #586
Labels
priority-2-moderate Should be resolved on a reasonable timeline.
Milestone
1.0.0

Comments

@rmorshea
Copy link
Collaborator

Current Situation

Currently we do not handle the case where the target-file already exists in module_from_template:

https://github.com/idom-team/idom/blob/0bf58771ac9fe0fa04853fbc33a2fdf614aaaed3/src/idom/web/module.py#L144-L150

Proposed Actions

Add a replace_existing option and raise an error if it is False and the target file exists.

Work Items

No response
@rmorshea rmorshea added flag-triage Not prioritized. priority-2-moderate Should be resolved on a reasonable timeline. type: bug and removed flag-triage Not prioritized. labels Jan 14, 2022
@rmorshea rmorshea added this to the 1.0 milestone Jan 14, 2022
@rmorshea rmorshea mentioned this issue Jan 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority-2-moderate Should be resolved on a reasonable timeline.
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Log on web module replacement instead of error reactive-python/reactpy
1 participant
@rmorshea