Skip to content

Use related_name for MTO queries #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 14, 2023
Merged

Use related_name for MTO queries #123

merged 3 commits into from
Jan 14, 2023

Conversation

Archmonger
Copy link
Contributor

Description

fix #122

Checklist:

Please update this checklist as you complete each item:

  • Tests have been included for all bug fixes or added functionality.
  • The changelog has been updated with any significant changes, if necessary.
  • GitHub Issues which may be closed by this PR have been linked.

@Archmonger Archmonger marked this pull request as ready for review January 13, 2023 23:45
rmorshea
rmorshea reviewed Jan 14, 2023
View reviewed changes
Copy link
Contributor

@rmorshea rmorshea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any regressions tests needed for this fix?

@Archmonger
Copy link
Contributor Author

Yes, I already bundled it into the existing use_query test

@rmorshea
Copy link
Contributor

Great. Missed that when looking on my phone.

@Archmonger Archmonger merged commit da5248e into reactive-python:main Jan 14, 2023
@Archmonger Archmonger deleted the fix-related-name branch January 14, 2023 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmorshea rmorshea rmorshea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use_query doesn't work with fields using modified related_name
2 participants
@Archmonger @rmorshea