-
Notifications
You must be signed in to change notification settings - Fork 475
docs: Update iOS Linking information #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update iOS Linking information #61
Conversation
docs: Update iOS manual linkining info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @clucasalcantara, thanks for your input!
I've left small comment, after you address it, it'd be ready to merge.
thanks.
chore: Update iOS manual link infor
Hey @krizzu :) Noted! I've made a few changes, please take a look :) |
Hey @clucasalcantara, Can you split thanks. |
chore: Split packaging and pod into sections
Sorry @krizzu , didn't noticed that :) I've split into step one and step two. |
Hey @clucasalcantara I would not call them You choose one of the way to link a library, otherwise you end up with same module, linked twice. thanks |
Hey @krizzu
|
What about |
Even better, on it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @clucasalcantara
Thank you so far for this. I've left two comments, please check them out. After that, we can merge it 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks a lot 🚀
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary:
After the discussions on issue #56 I've noticed that we have missing information about iOS Linking and almost none about the manual linking process, this PR aims to provide this missing info.
Test Plan:
No needed, only docs changes.