Skip to content

rename filenames in code to match case-sensitively real filenames #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 1, 2019
Merged

rename filenames in code to match case-sensitively real filenames #26

merged 2 commits into from
Mar 1, 2019

Conversation

sylvainbaronnet
Copy link
Contributor

No description provided.

@sylvainbaronnet sylvainbaronnet mentioned this pull request Feb 28, 2019
Closed
@krizzu krizzu added bug Something isn't working platform: iOS This is iOS specific labels Feb 28, 2019
@krizzu
Copy link
Member

krizzu commented Feb 28, 2019

Looks great 👍
Can you also commit changed Example app? I believe there're places where it still has old Asyncstorage name, so I guess that's worth to update too.

Thanks!

@sylvainbaronnet
Copy link
Contributor Author

I renamed all Asyncstorage to AsyncStorage including RNCAsyncStorage.xcodeproj folder

krizzu
krizzu approved these changes Mar 1, 2019
View reviewed changes
Copy link
Member

@krizzu krizzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🥇

Thanks.

@krizzu krizzu merged commit 8eba217 into react-native-async-storage:master Mar 1, 2019
@krizzu
Copy link
Member

krizzu commented Mar 1, 2019

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@krizzu krizzu added the released label Mar 1, 2019
@sylvainbaronnet sylvainbaronnet deleted the rename-file branch March 3, 2019 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krizzu krizzu krizzu approved these changes

Assignees
No one assigned
Labels
bug Something isn't working platform: iOS This is iOS specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sylvainbaronnet @krizzu