Skip to content

Build error RNCAsyncstorage.m not found #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sylvainbaronnet opened this issue Feb 27, 2019 · 6 comments
Closed

Build error RNCAsyncstorage.m not found #23

sylvainbaronnet opened this issue Feb 27, 2019 · 6 comments
Labels
bug Something isn't working platform: iOS This is iOS specific

Comments

@sylvainbaronnet
Copy link
Contributor

sylvainbaronnet commented Feb 27, 2019

Hi,

Edit: with version 1.0.2

There's a typo in RNCAsyncStorage.m filename, which is RNCAsyncstorage.m in build (notice the S of Storage)

error: Build input file cannot be found: '/Users/.../node_modules/@react-native-community/async-storage/ios/RNCAsyncstorage.m'

I tried to rename the file and it works

@sylvainbaronnet
Copy link
Contributor Author

My HD is APFS (Case-sensitive) so it might be the reason (maybe it works on Case-insensitive HD ?)

@krizzu krizzu added bug Something isn't working platform: iOS This is iOS specific labels Feb 27, 2019
@krizzu
Copy link
Member

krizzu commented Feb 27, 2019

Thanks for reporting this.
I just initialized repo and tested Async Storage 1.0.2 from npm. Everything works.
But it's worth to fix it, to avoid issues in the future.

Do you mind opening PR with changes?

Thanks.

@sylvainbaronnet
Copy link
Contributor Author

Sure, just renaming the file works for you ?

@krizzu
Copy link
Member

krizzu commented Feb 28, 2019

I'd like to keep filename in camel case. Changing occurrences of Asyncstorage into AsyncStorage will do the job.

Also, to confirm everything works, after you apply changes, you can unlink AsyncStorage from example project and link it back manually, to see if it builds/works normally.

Thanks.

@sylvainbaronnet
Copy link
Contributor Author

see : #26

@krizzu
Copy link
Member

krizzu commented Mar 1, 2019

Closing with #26 merged

@krizzu krizzu closed this as completed Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working platform: iOS This is iOS specific
Projects
None yet
Development

No branches or pull requests

2 participants