Add required changes for svelte@4 #811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visual diff results for latest changes ✅ There are no visual differences between |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
sebastinez
force-pushed
the
sebastinez/update-svelte-4
branch
2 times, most recently
from
14ae7f3 to
222d6d6
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sebastinez
force-pushed
the
sebastinez/update-svelte-4
branch
from
222d6d6 to
0c34002
Compare
sebastinez
force-pushed
the
sebastinez/update-svelte-4
branch
from
0c34002 to
f3c2103
Compare
sebastinez
force-pushed
the
sebastinez/update-svelte-4
branch
from
0237248 to
21582d4
Compare
sebastinez
force-pushed
the
sebastinez/update-svelte-4
branch
from
21582d4 to
b76ae23
Compare
sebastinez
force-pushed
the
sebastinez/update-svelte-4
branch
2 times, most recently
from
9b45ff9 to
dd01700
Compare
Signed-off-by: Sebastian Martinez <[email protected]>
rudolfs
force-pushed
the
sebastinez/update-svelte-4
branch
from
dd01700 to
ba57506
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point soon Svelte@4 is going to be released, here are some changes that will be required or beneficial, for our codebase.
|localis now the default behaviour for transitions so I removed it from the codebase.SvelteComponentTypedhas been deprecated in favor ofSvelteComponentCobStateButtonmore explicit to only takeIssueStatecurrently, since Svelte@4 is stricter oncreateEventDispatcher, we should be able to add more types when needed.Pending:
ComponentTypenot exported by Svelte v4:sveltedoesn't exportComponentTypesveltejs/svelte#8692