Skip to content

Commit 14ae7f3

Browse files
committed
Add required changes for svelte@4
Signed-off-by: Sebastian Martinez <[email protected]>
1 parent 2af304e commit 14ae7f3

File tree

15 files changed

+808
-111
lines changed

15 files changed

+808
-111
lines changed

package-lock.json

Lines changed: 783 additions & 99 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -28,24 +28,24 @@
2828
"@types/lodash": "^4.14.195",
2929
"@types/marked": "^5.0.0",
3030
"@types/md5": "^2.3.2",
31-
"@types/node": "^18.16.12",
31+
"@types/node": "^18.16.16",
3232
"@types/sinon": "^10.0.15",
3333
"@types/sinonjs__fake-timers": "^8.1.2",
3434
"@types/wait-on": "^5.3.1",
3535
"@typescript-eslint/eslint-plugin": "^5.59.8",
3636
"chalk": "^5.2.0",
37-
"eslint": "^8.41.0",
38-
"eslint-plugin-svelte": "^2.29.0",
37+
"eslint": "^8.42.0",
38+
"eslint-plugin-svelte": "^2.30.0",
3939
"execa": "^7.1.1",
4040
"exit-hook": "^3.2.0",
41-
"get-port": "^6.1.2",
41+
"get-port": "^7.0.0",
4242
"happy-dom": "^9.20.3",
4343
"prettier": "^2.8.8",
4444
"prettier-plugin-svelte": "^2.10.1",
4545
"svelte-check": "^3.4.3",
46-
"typescript": "^5.0.4",
46+
"typescript": "^5.1.3",
4747
"vite": "^4.3.9",
48-
"vitest": "^0.31.2",
48+
"vitest": "^0.31.4",
4949
"wait-on": "^7.0.1"
5050
},
5151
"dependencies": {
@@ -64,7 +64,7 @@
6464
"md5": "^2.3.0",
6565
"plausible-tracker": "^0.3.8",
6666
"sinon": "^15.1.0",
67-
"svelte": "^3.59.1",
67+
"svelte": "^4.0.0-next.0",
6868
"twemoji": "^14.0.2",
6969
"zod": "^3.21.4"
7070
}

src/App/ColorPaletteModal.svelte

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,7 @@
134134

135135
<Modal closeAction={false}>
136136
<!-- svelte-ignore a11y-click-events-have-key-events -->
137+
<!-- svelte-ignore a11y-no-static-element-interactions -->
137138
<div slot="body">
138139
<div class="container" on:click={() => (checkers = !checkers)}>
139140
<div class:checkers>

src/App/Header/Connect.svelte

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@
120120
</Link>
121121

122122
<!-- svelte-ignore a11y-click-events-have-key-events -->
123+
<!-- svelte-ignore a11y-no-static-element-interactions -->
123124
<div
124125
class="dropdown-button rounded"
125126
on:click={() => {

src/App/Header/SettingsDropdown.svelte

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@
9292
<ThemeToggle />
9393
</div>
9494
<!-- svelte-ignore a11y-click-events-have-key-events -->
95+
<!-- svelte-ignore a11y-no-static-element-interactions -->
9596
<div
9697
class="item selector"
9798
on:click|stopPropagation={() => (showFonts = !showFonts)}>
@@ -101,10 +102,11 @@
101102
{#if showFonts}
102103
<div
103104
class="fonts"
104-
transition:slide|local={{ duration: 150, easing: quadIn }}>
105+
transition:slide={{ duration: 150, easing: quadIn }}>
105106
{#each codeFonts as font}
106107
{@const isSelectedFont = $codeFont === font.storedName}
107108
<!-- svelte-ignore a11y-click-events-have-key-events -->
109+
<!-- svelte-ignore a11y-no-static-element-interactions -->
108110
<div
109111
on:click={() => switchFont(font.storedName)}
110112
class="item font"

src/App/ModalPortal.svelte

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
{#if $modalStore}
3131
<div class="container">
3232
<!-- svelte-ignore a11y-click-events-have-key-events -->
33+
<!-- svelte-ignore a11y-no-static-element-interactions -->
3334
<div
3435
class="overlay"
3536
on:click={hide}

src/components/Badge.svelte

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
}
5050
</style>
5151

52+
<!-- svelte-ignore a11y-no-static-element-interactions -->
5253
<span
5354
on:mouseenter
5455
on:mouseleave

src/components/Clipboard.svelte

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
</style>
5151

5252
<!-- svelte-ignore a11y-click-events-have-key-events -->
53+
<!-- svelte-ignore a11y-no-static-element-interactions -->
5354
<span
5455
title={tooltip}
5556
class="clipboard"

src/components/Dropdown/DropdownItem.svelte

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
</style>
2525

2626
<!-- svelte-ignore a11y-click-events-have-key-events -->
27+
<!-- svelte-ignore a11y-no-static-element-interactions -->
2728
<div
2829
class="item"
2930
class:selected

src/components/Floating.svelte

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@
4343

4444
<div bind:this={thisComponent}>
4545
<!-- svelte-ignore a11y-click-events-have-key-events -->
46+
<!-- svelte-ignore a11y-no-static-element-interactions -->
4647
<div
4748
on:click={toggle}
4849
class="toggle"

src/components/Icon.svelte

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
</style>
3636

3737
<!-- svelte-ignore a11y-click-events-have-key-events -->
38+
<!-- svelte-ignore a11y-no-noninteractive-element-interactions -->
3839
<svg
3940
role="img"
4041
on:click

src/components/SquareButton.svelte

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@
6363
</style>
6464

6565
<!-- svelte-ignore a11y-click-events-have-key-events -->
66+
<!-- svelte-ignore a11y-no-static-element-interactions -->
6667
<div
6768
{title}
6869
on:click

src/lib/modal.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { derived, get, writable } from "svelte/store";
22
import type {
33
ComponentProps,
44
ComponentType,
5-
SvelteComponentTyped,
5+
SvelteComponent,
66
} from "svelte";
77

88
type HideCallback = () => void;
@@ -45,13 +45,13 @@ export function hide(): void {
4545
store.set(undefined);
4646
}
4747

48-
interface ShowArgs<T extends SvelteComponentTyped> {
48+
interface ShowArgs<T extends SvelteComponent> {
4949
component: ComponentType<T>;
5050
props: ComponentProps<T>;
5151
hideCallback?: HideCallback;
5252
}
5353

54-
export function show<Component extends SvelteComponentTyped>(
54+
export function show<Component extends SvelteComponent>(
5555
args: ShowArgs<Component>,
5656
): void {
5757
// Defocus any active input elements, so that we can always close an open
@@ -62,7 +62,7 @@ export function show<Component extends SvelteComponentTyped>(
6262
store.set(args);
6363
}
6464

65-
export function toggle<Component extends SvelteComponentTyped>(
65+
export function toggle<Component extends SvelteComponent>(
6666
args: ShowArgs<Component>,
6767
): void {
6868
const stored = get(modalStore);

src/views/projects/SourceBrowser/FileDiff.svelte

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,7 @@
153153
<div id={file.path} class="wrapper">
154154
<header class="header">
155155
<!-- svelte-ignore a11y-click-events-have-key-events -->
156+
<!-- svelte-ignore a11y-no-static-element-interactions -->
156157
<div class="expand-button" on:click={() => (collapsed = !collapsed)}>
157158
{#if collapsed}
158159
<Icon name="chevron-right" />

src/views/projects/Tree/Folder.svelte

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@
6868
</style>
6969

7070
<!-- svelte-ignore a11y-click-events-have-key-events -->
71+
<!-- svelte-ignore a11y-no-static-element-interactions -->
7172
<div class="folder" on:click={onClick}>
7273
<span class="folder-name">{name}/</span>
7374
</div>

0 commit comments

Comments
 (0)