Add support for single active consumer #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acogoluegnes
force-pushed
the
single-active-consumer
branch
4 times, most recently
from
7556e0a to
1481930
Compare
acogoluegnes
force-pushed
the
single-active-consumer
branch
3 times, most recently
from
b3cc4ae to
0388ff4
Compare
acogoluegnes
force-pushed
the
single-active-consumer
branch
from
90ab4ca to
e4c459c
Compare
acogoluegnes
force-pushed
the
single-active-consumer
branch
from
e4c459c to
0121c44
Compare
acogoluegnes
force-pushed
the
single-active-consumer
branch
3 times, most recently
from
124bef0 to
cf58107
Compare
acogoluegnes
force-pushed
the
single-active-consumer
branch
from
29b1a3e to
c8d9ec3
Compare
acogoluegnes
force-pushed
the
single-active-consumer
branch
3 times, most recently
from
96a0888 to
93a6c35
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## main #94 +/- ##
============================================
+ Coverage 82.42% 82.50% +0.08%
+ Complexity 1049 1020 -29
============================================
Files 78 76 -2
Lines 7054 6849 -205
Branches 725 707 -18
============================================
- Hits 5814 5651 -163
+ Misses 890 864 -26
+ Partials 350 334 -16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
acogoluegnes
force-pushed
the
single-active-consumer
branch
2 times, most recently
from
a1727fd to
d93ef42
Compare
acogoluegnes
force-pushed
the
single-active-consumer
branch
from
bbc26f4 to
b8f9088
Compare
References rabbitmq/rabbitmq-server#3753 Conflicts: src/main/java/com/rabbitmq/stream/Constants.java src/main/java/com/rabbitmq/stream/impl/Client.java src/main/java/com/rabbitmq/stream/impl/ServerFrameHandler.java
References rabbitmq/rabbitmq-server#3753 Conflicts: src/test/java/com/rabbitmq/stream/impl/SingleActiveConsumerTest.java
Instead of client-side in-memory tracking, because it's more realistic. References rabbitmq/rabbitmq-server#3753 Conflicts: src/test/java/com/rabbitmq/stream/impl/SingleActiveConsumerTest.java
WIP. References rabbitmq/rabbitmq-server#3753 Conflicts: src/main/java/com/rabbitmq/stream/impl/OffsetTrackingCoordinator.java src/main/java/com/rabbitmq/stream/impl/StreamConsumer.java Conflicts: src/main/java/com/rabbitmq/stream/impl/StreamConsumer.java Conflicts: src/test/java/com/rabbitmq/stream/impl/SingleActiveConsumerTest.java
To mimick custom offset tracking. References rabbitmq/rabbitmq-server#3753
To disable server-side offset tracking. Useful when SAC is enabled and external storage is used for offset tracking. References #46
References #46
References #46
References #46 Conflicts: pom.xml
In performance tool documentation.
Setting the SAC status to false is safe when the connection is lost, even if no notification came. This makes sure the consumer instance state is consistent, as a new SAC consumer is always inactive when it first registers. References #46
Conflicts: src/main/java/com/rabbitmq/stream/impl/OffsetTrackingCoordinator.java src/main/java/com/rabbitmq/stream/impl/StreamConsumer.java src/test/java/com/rabbitmq/stream/impl/StreamConsumerTest.java
Make mock consumer returns it's open.
It's already done in a decorating message handler, in the consumer itself. References #142
When created from performance tool.
The artifact can deleted from the repository afterwards.
Conflicts: src/docs/asciidoc/setup.adoc
To make sure messages with a given key (e.g. user name) end up in the same partition.
Not mandatory, but for consistency with ConsumerBuilder#superStream(String).
In documentation.
acogoluegnes
force-pushed
the
single-active-consumer
branch
from
9353dc5 to
0e7e9a8
Compare
Refactor also the JUnit conditions to check the broker version.
pivotal-rabbitmq-ci
pushed a commit
that referenced
this pull request
Aug 11, 2022
Add support for single active consumer
pivotal-rabbitmq-ci
pushed a commit
that referenced
this pull request
Aug 11, 2022
Add support for single active consumer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation.
Fixes #46.