Skip to content

Add support for single active consumer and super streams #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
acogoluegnes opened this issue Dec 1, 2021 · 1 comment · Fixed by #94
Closed

Add support for single active consumer and super streams #46

acogoluegnes opened this issue Dec 1, 2021 · 1 comment · Fixed by #94
Assignees
@acogoluegnes
Labels
enhancement New feature or request
Milestone
0.7.0

Comments

@acogoluegnes
Copy link
Contributor

acogoluegnes commented Dec 1, 2021 •
edited
Loading

References rabbitmq/rabbitmq-server#3753.
@acogoluegnes acogoluegnes self-assigned this Dec 1, 2021
@acogoluegnes acogoluegnes added the enhancement New feature or request label Dec 1, 2021
acogoluegnes added a commit that referenced this issue Dec 1, 2021
@acogoluegnes
Add SAC test with manual offset tracking
6705c24 
Requires to add Consumer#storedOffset() to let the user
make sure the stored offset request made it to the
broker before closing the consumer.

References #46, rabbitmq/rabbitmq-server#3753
@acogoluegnes
Copy link
Contributor Author

May require to add Consumer#storedOffset(), see 6705c24.

acogoluegnes added a commit that referenced this issue Dec 2, 2021
@acogoluegnes
Add SAC branch to changes from main
ccfacf9 
Mainly queryOffset returning QueryOffsetResponse instead of
just a long.

References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Dec 2, 2021
@acogoluegnes
Add SAC test with manual offset tracking
6a253c3 
Requires to add Consumer#storedOffset() to let the user
make sure the stored offset request made it to the
broker before closing the consumer.

References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Dec 2, 2021
@acogoluegnes
Add SAC branch to changes from main
6c09346 
Mainly queryOffset returning QueryOffsetResponse instead of
just a long.

References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Dec 2, 2021
@acogoluegnes
Add SAC test with manual offset tracking
0f2b2ff 
Requires to add Consumer#storedOffset() to let the user
make sure the stored offset request made it to the
broker before closing the consumer.

References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Dec 3, 2021
@acogoluegnes
Handle no offset response in default consumer update handler
e5ae4a5 
References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Dec 6, 2021
@acogoluegnes
Add SAC super stream test with manual offset tracking
a840962 
Using server-side offset tracking.

References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Dec 6, 2021
@acogoluegnes
Add SAC super stream test with custom offset tracking
f497642 
References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Dec 9, 2021
@acogoluegnes
Put SAC-related tests in their own classes
ece858a 
References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Dec 10, 2021
@acogoluegnes
Add SAC branch to changes from main
bff56b5 
Mainly queryOffset returning QueryOffsetResponse instead of
just a long.

References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Dec 10, 2021
@acogoluegnes
Add SAC test with manual offset tracking
2b19edc 
Requires to add Consumer#storedOffset() to let the user
make sure the stored offset request made it to the
broker before closing the consumer.

References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Dec 10, 2021
@acogoluegnes
Handle no offset response in default consumer update handler
640d4a7 
References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Dec 10, 2021
@acogoluegnes
Add SAC super stream test with manual offset tracking
1c88c1e 
Using server-side offset tracking.

References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Dec 10, 2021
@acogoluegnes
Add SAC super stream test with custom offset tracking
3610890 
References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Dec 10, 2021
@acogoluegnes
Put SAC-related tests in their own classes
27b99ef 
References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Dec 15, 2021
@acogoluegnes
Adapt SAC tests to SAC coordinator refactoring
88ea888 
The (de)activation protocol changed a bit internally. New consumers
assume they are passive by default, until they are activated
(no passive update notification if the consumer was not active
previously).

References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Dec 16, 2021
@acogoluegnes
Add SAC branch to changes from main
e40d041 
Mainly queryOffset returning QueryOffsetResponse instead of
just a long.

References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Dec 16, 2021
@acogoluegnes
Add SAC test with manual offset tracking
242bd57 
Requires to add Consumer#storedOffset() to let the user
make sure the stored offset request made it to the
broker before closing the consumer.

References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Dec 16, 2021
@acogoluegnes
Handle no offset response in default consumer update handler
4beac75 
References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Dec 16, 2021
@acogoluegnes
Add SAC super stream test with manual offset tracking
27e4ca3 
Using server-side offset tracking.

References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Dec 16, 2021
@acogoluegnes
Add SAC super stream test with custom offset tracking
4574241 
References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Dec 16, 2021
@acogoluegnes
Put SAC-related tests in their own classes
ea94d7b 
References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Dec 16, 2021
@acogoluegnes
Adapt SAC tests to SAC coordinator refactoring
1df6214 
The (de)activation protocol changed a bit internally. New consumers
assume they are passive by default, until they are activated
(no passive update notification if the consumer was not active
previously).

References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Dec 16, 2021
@acogoluegnes
Add SAC branch to changes from main
9e2fdf5 
Mainly queryOffset returning QueryOffsetResponse instead of
just a long.

References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Dec 16, 2021
@acogoluegnes
Add SAC test with manual offset tracking
b1e8efc 
Requires to add Consumer#storedOffset() to let the user
make sure the stored offset request made it to the
broker before closing the consumer.

References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Dec 16, 2021
@acogoluegnes
Handle no offset response in default consumer update handler
f52bb46 
References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Dec 16, 2021
@acogoluegnes
Add SAC super stream test with manual offset tracking
71c8106 
Using server-side offset tracking.

References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Jul 13, 2022
@acogoluegnes
Set SAC status to false when connection is lost
f18dcd1 
Setting the SAC status to false is safe when the connection
is lost, even if no notification came. This makes sure
the consumer instance state is consistent, as a new SAC consumer
is always inactive when it first registers.

References #46
@acogoluegnes acogoluegnes added this to the 0.7.0 milestone Aug 4, 2022
acogoluegnes added a commit that referenced this issue Aug 10, 2022
@acogoluegnes
Add SAC branch to changes from main
a6ba730 
Mainly queryOffset returning QueryOffsetResponse instead of
just a long.

References #46, rabbitmq/rabbitmq-server#3753

Conflicts:
	src/main/java/com/rabbitmq/stream/impl/OffsetTrackingCoordinator.java
acogoluegnes added a commit that referenced this issue Aug 10, 2022
@acogoluegnes
Add SAC test with manual offset tracking
003eea8 
Requires to add Consumer#storedOffset() to let the user
make sure the stored offset request made it to the
broker before closing the consumer.

References #46, rabbitmq/rabbitmq-server#3753

Conflicts:
	src/main/java/com/rabbitmq/stream/impl/OffsetTrackingCoordinator.java
acogoluegnes added a commit that referenced this issue Aug 10, 2022
@acogoluegnes
Handle no offset response in default consumer update handler
78999b4 
References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Aug 10, 2022
@acogoluegnes
Add SAC super stream test with manual offset tracking
30bc15d 
Using server-side offset tracking.

References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Aug 10, 2022
@acogoluegnes
Add SAC super stream test with custom offset tracking
d07b3d3 
References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Aug 10, 2022
@acogoluegnes
Put SAC-related tests in their own classes
7a487d8 
References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Aug 10, 2022
@acogoluegnes
Adapt SAC tests to SAC coordinator refactoring
e553017 
The (de)activation protocol changed a bit internally. New consumers
assume they are passive by default, until they are activated
(no passive update notification if the consumer was not active
previously).

References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Aug 10, 2022
@acogoluegnes
Add test for SAC + connection killing
3b61ad7 
The stream SAC coordinator monitors connection processes
and should send consumer update accordingly when connections
die.

References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Aug 10, 2022
@acogoluegnes
Add SAC test with different groups on same super stream
a385665 
References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Aug 10, 2022
@acogoluegnes
Add test to check SAC must have a name
befd3b9 
References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Aug 10, 2022
@acogoluegnes
Increase publishing rate in test
2210495 
Otherwise the expected response code may not be received
because there's no enough concurrency. This way an error
path is exercised on the broker side.

References #46, rabbitmq/rabbitmq-server#3753
acogoluegnes added a commit that referenced this issue Aug 10, 2022
@acogoluegnes
Add Javadoc for single active consumer API
c82cae0 
References #46
acogoluegnes added a commit that referenced this issue Aug 10, 2022
@acogoluegnes
Document single active consumer
12d6600 
References #46
acogoluegnes added a commit that referenced this issue Aug 10, 2022
@acogoluegnes
Start documenting SAC in super stream consumer
e99df5a 
References #46
acogoluegnes added a commit that referenced this issue Aug 10, 2022
@acogoluegnes
Start documenting API for SAC and super stream
273988a 
References #46
acogoluegnes added a commit that referenced this issue Aug 10, 2022
@acogoluegnes
Use active flag in consumer update listener
bd8b503 
Instead of state enum. This is a boolean, and as the consumer
is notified only of a state change, it does not have
to know about the previous state.

References #46

Conflicts:
	src/main/java/com/rabbitmq/stream/impl/OffsetTrackingCoordinator.java
	src/main/java/com/rabbitmq/stream/impl/StreamConsumer.java
acogoluegnes added a commit that referenced this issue Aug 10, 2022
@acogoluegnes
Mention SAC is available as of RabbitMQ 3.11
e05c7ba 
References #46
acogoluegnes added a commit that referenced this issue Aug 10, 2022
@acogoluegnes
Introduce NoOffsetException
9ceffc5 
Thrown when no stored offset is found. Better than checking
response code.

References #46

Conflicts:
	src/main/java/com/rabbitmq/stream/impl/OffsetTrackingCoordinator.java
acogoluegnes added a commit that referenced this issue Aug 10, 2022
@acogoluegnes
Document manual offset tracking for super stream SAC
547c875 
References #46
acogoluegnes added a commit that referenced this issue Aug 10, 2022
@acogoluegnes
Add ConsumerBuilder#noTrackingStrategy()
8a32195 
To disable server-side offset tracking. Useful when SAC is enabled
and external storage is used for offset tracking.

References #46
acogoluegnes added a commit that referenced this issue Aug 10, 2022
@acogoluegnes
Document super stream SAC and external storage for offset tracking
c6241d7 
References #46
acogoluegnes added a commit that referenced this issue Aug 10, 2022
@acogoluegnes
Add figures for SAC
7660c38 
References #46
acogoluegnes added a commit that referenced this issue Aug 10, 2022
@acogoluegnes
Add figure for SAC + super stream
5067cf9 
References #46
acogoluegnes added a commit that referenced this issue Aug 10, 2022
@acogoluegnes
Add support for super stream + SAC in performance tool
4d7650f 
References #46

Conflicts:
	pom.xml
acogoluegnes added a commit that referenced this issue Aug 10, 2022
@acogoluegnes
Document SAC and super stream usage in performance tool
f956461 
References #46
acogoluegnes added a commit that referenced this issue Aug 10, 2022
@acogoluegnes
Set SAC status to false when connection is lost
ab04038 
Setting the SAC status to false is safe when the connection
is lost, even if no notification came. This makes sure
the consumer instance state is consistent, as a new SAC consumer
is always inactive when it first registers.

References #46
@acogoluegnes acogoluegnes changed the title Add support for single active consumer Add support for single active consumer and super streams Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acogoluegnes acogoluegnes

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

Add support for single active consumer rabbitmq/rabbitmq-stream-java-client
1 participant
@acogoluegnes