Make SslContext creation more flexible #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce the SslContextFactory interface, in use in the ConnectionFactory to create SslContext instance based on the connection name. The existing ConnectionFactory#useSslProtocol() methods still work the same way (they end using a SslContextFactory that returns the same SslContext, whatever the name of the connection is). This introduces a breaking change in the FrameHandlerFactory by adding a new connectionName parameter. It should impact many users, as this is more an internal API. Fixes #241
michaelklishin
approved these changes
May 20, 2017
and avoids an NPE.
While not something end user code should depend on, it did trip up a couple of our tests. Be more defensive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the SslContextFactory interface, in use in the ConnectionFactory
to create SslContext instance based on the connection name.
The existing ConnectionFactory#useSslProtocol() methods still work
the same way (they end using a SslContextFactory that returns the
same SslContext, whatever the name of the connection is).
This introduces a breaking change in the FrameHandlerFactory
by adding a new connectionName parameter. It should impact many
users, as this is more an internal API.
Fixes #241