Skip to content

Make SslContext creation more flexible #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
acogoluegnes opened this issue Feb 13, 2017 · 2 comments
Closed

Make SslContext creation more flexible #241

acogoluegnes opened this issue Feb 13, 2017 · 2 comments
Assignees
@acogoluegnes
Labels
effort-low enhancement usability
Milestone
5.0.0

Comments

@acogoluegnes
Copy link
Contributor

acogoluegnes commented Feb 13, 2017 •
edited
Loading

E.g. allow to have a SslContext created for each connection of the same ConnectionFactory.

See https://groups.google.com/d/msg/rabbitmq-users/Jl5ffHgueDw/1bUsPxzYEAAJ.
@acogoluegnes
Copy link
Contributor Author

This would typically require API changes, e.g. in FrameHandlerFactory.

@acogoluegnes acogoluegnes added this to the 5.0.0 milestone Feb 20, 2017
@vibhuyadav
Copy link

This would be a great addition

@acogoluegnes acogoluegnes self-assigned this May 18, 2017
acogoluegnes added a commit that referenced this issue May 19, 2017
@acogoluegnes
Make SslContext creation more flexible
c8852fa 
Introduce the SslContextFactory interface, in use in the ConnectionFactory
to create SslContext instance based on the connection name.
The existing ConnectionFactory#useSslProtocol() methods still work
the same way (they end using a SslContextFactory that returns the
same SslContext, whatever the name of the connection is).
This introduces a breaking change in the FrameHandlerFactory
by adding a new connectionName parameter. It should impact many
users, as this is more an internal API.

Fixes #241
@acogoluegnes acogoluegnes mentioned this issue May 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acogoluegnes acogoluegnes

Labels
effort-low enhancement usability
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
2 participants
@acogoluegnes @vibhuyadav