ValidationError -- better detail

[ghost]

Julian,

I modified your code to have ValidationError provide more detail

In [15]: try:
   ....:        jsonschema.validate(message, EVENT_TYPE_CREATE, stop_on_error=False)
   ....: except jsonschema.ValidationError as err:
   ....:        print err.detail
   ....: 
{'organized_flag': [u"'yes' is not of type 'boolean'"], 'parent_id': [u'-30 is less than the minimum of 0'], 'name': [u"'name' is a required property"]}

ie.,
https://gist.github.com/2158863

would there be a reason not to do this?

Cheers,
-K

[Julian]

Hi.

That looks ok for objects just from taking a quick peek, but how about when
you're validating, say, an array?

[ghost]

Good point.

    def validate_minItems(self, mI, instance, schema, property):
        if self._is_type(instance, "array") and len(instance) < mI:
            self._error(u"%r is too short" % (instance,), property)

    def validate_maxItems(self, mI, instance, schema, property):
        if self._is_type(instance, "array") and len(instance) > mI:
            self._error(u"%r is too long" % (instance,), property)

Is there anywhere that traverses inside the array to check the correct value types? I think we'd want to make sure the property name is still passed through.

How do I run your tests again the code update?

How would you approach it? The reason we're developing this is so not only is there human readable error messages, but we can also machine read and know what 'property' has errors, etc.

Cheers

[Julian]

Is there anywhere that traverses inside the array to check the correct value types? I think we'd want to make sure the property name is still passed through.

That validation would happen inside validate_items (the validation is
basically just like walking a tree, similar to ast.NodeVisitor in case
you're familiar). But, what I meant was, what if your entire instance is
just an array, then you'd have no key / property to store at all. How would
details behave there?

How do I run your tests again the code update?

If you've got tox installed you can just run tox in the root of the
checkout. Otherwise just run your favorite test runner, say trial tests
or nosetests also from the checkout.

How would you approach it? The reason we're developing this is so not only is there human readable error messages, but we can also machine read and know what 'property' has errors, etc.

Yeah, I can definitely appreciate making the errors more structured here
once we can just iron out the behavior for all the cases.

[ghost]

Julian,

Can you drop me an email at kevin at mapmy fitness dotcom? Would like to explore something with you...

Cheers,

-Kevin