Skip to content

Optimize extends #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Julian opened this issue Feb 24, 2012 · 3 comments
Closed

Optimize extends #3

Julian opened this issue Feb 24, 2012 · 3 comments

Comments

@Julian
Copy link
Member

Julian commented Feb 24, 2012

See the draft for suggestions, but we can cut down on validating things twice by taking time to combine the two schemas intelligently

@Julian Julian closed this as completed in c41787b Dec 25, 2012
@Julian
Copy link
Member Author

Julian commented Jan 30, 2013

Ugh git(hub) you are terrible.

@Julian Julian reopened this Jan 30, 2013
@gazpachoking
Copy link
Contributor

So, I guess this would apply to allOf in draft 4, but I'm not sure this will be worth it. For one, if we create a combined schema, giving the proper schema_path in errors gets quite a bit tougher.

@Julian
Copy link
Member Author

Julian commented May 2, 2013

Sounds good. I don't have any desire to do this, so let's close it.
On May 2, 2013 3:45 PM, "Chase Sterling" [email protected] wrote:

So, I guess this would apply to allOf in draft 4, but I'm not sure this
will be worth it. For one, if we create a combined schema, giving the
proper schema_path in errors gets quite a bit tougher.


Reply to this email directly or view it on GitHubhttps://github.com//issues/3#issuecomment-17360171
.

Julian added a commit that referenced this issue Jul 26, 2019
c09f995c Spell checkin'.
93b5387c Merge pull request #271 from Zac-HD/hypothesis-tests
fddd43bd booleans are not equal to numbers
d8a820aa Nested anyOf test
0c0fdc12 Add hypothesis-jsonschema to README
59181b43 updated 'output' subschema
664aa98a Optionally allow an output property.
4bd56e35 Merge pull request #270 from ahx/patch-1
8be471df Add json_schemer to list to implementors
9cbad896 Merge remote-tracking branch 'gregsdennis/defs'
12a62baf Show a more helpful message when someone forgets to update both remotes locations.
f43e07fe added new remote to appropriate files
1ce104fb un-add draft2019-04
2a68cdd5 updated some references to previous drafts; created new name remote for $defs
19803ceb Merge pull request #3 from json-schema-org/defs
a6e836c6 Merge pull request #2 from json-schema-org/master
65e3480c Rename definitions to $defs in the 2019-06 draft.
366f15bd added initial set of tests (with expected output) for draft/2019-04
147da3d2 Merge pull request #1 from json-schema-org/master

git-subtree-dir: json
git-subtree-split: c09f995c94d6f0e004e7be32d6de74e331ecbfa0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants