-
Notifications
You must be signed in to change notification settings - Fork 159
Remove support for python3.8 #968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for python3.8 #968
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #968 +/- ##
=======================================
Coverage 91.10% 91.10%
=======================================
Files 2 2
Lines 506 506
Branches 64 64
=======================================
Hits 461 461
Misses 27 27
Partials 18 18 ☔ View full report in Codecov by Sentry. |
It would be nice to have pyupgrade in pre-commit to automate syntax bumps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you interested in us adding some tooling @seifertm ? (ruff can replace flake8 for example, and it's possible to migrate to pyproject.toml). I would have added the UP
check if ruff was already configured.
Absolutely. I'm very open to these tooling updates. |
Python 3.8 received its last security release on 2024-09-06 and is now end of life.
see https://peps.python.org/pep-0569/