Skip to content

Remove support for python3.8 #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

seifertm
Copy link
Contributor

Python 3.8 received its last security release on 2024-09-06 and is now end of life.

see https://peps.python.org/pep-0569/

@seifertm seifertm added this to the v1.0 milestone Oct 23, 2024
@seifertm seifertm marked this pull request as ready for review October 23, 2024 17:04
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.10%. Comparing base (90ce06a) to head (2634d25).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #968   +/-   ##
=======================================
  Coverage   91.10%   91.10%           
=======================================
  Files           2        2           
  Lines         506      506           
  Branches       64       64           
=======================================
  Hits          461      461           
  Misses         27       27           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@webknjaz
Copy link
Member

It would be nice to have pyupgrade in pre-commit to automate syntax bumps.

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you interested in us adding some tooling @seifertm ? (ruff can replace flake8 for example, and it's possible to migrate to pyproject.toml). I would have added the UP check if ruff was already configured.

@seifertm
Copy link
Contributor Author

Are you interested in us adding some tooling @seifertm ? (ruff can replace flake8 for example, and it's possible to migrate to pyproject.toml). I would have added the UP check if ruff was already configured.

Absolutely. I'm very open to these tooling updates.
I use ruff in other projects and it works just fine. Pyupgrade is also an option.

@seifertm seifertm added this pull request to the merge queue Oct 24, 2024
Merged via the queue into pytest-dev:main with commit 07b19a9 Oct 24, 2024
15 checks passed
@seifertm seifertm deleted the remove-support-for-python3.8 branch October 24, 2024 04:21
@seifertm seifertm restored the remove-support-for-python3.8 branch October 30, 2024 19:35
@seifertm seifertm deleted the remove-support-for-python3.8 branch December 13, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants