Skip to content

[pre-commit.ci] pre-commit autoupdate #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Oct 14, 2024

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 6f9cd2b to b85b819 Compare October 21, 2024 23:01
@webknjaz
Copy link
Member

The changes to type imports here break Python 3.8 compat in runtime. One solution could be quoting the affected types, I think. Alternatively, from __future__ import annotations should work. And finally, support for Python 3.8 could be dropped as it's EoL now.

@Pierre-Sassoulas
Copy link
Member

Will be fixed by #968 and #969

@Pierre-Sassoulas
Copy link
Member

pre-commit.ci run

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.15%. Comparing base (e40623d) to head (6d2e2a6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #963   +/-   ##
=======================================
  Coverage   91.15%   91.15%           
=======================================
  Files           2        2           
  Lines         509      509           
  Branches       64       64           
=======================================
  Hits          464      464           
  Misses         27       27           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pierre-Sassoulas Pierre-Sassoulas force-pushed the pre-commit-ci-update-config branch from 4f508c3 to 6d2e2a6 Compare October 28, 2024 12:07
@Pierre-Sassoulas
Copy link
Member

Made another autoupdate and rebased manually properly as it's impossible to squash by settings.

@Pierre-Sassoulas Pierre-Sassoulas added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit 2609b7a Oct 28, 2024
15 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the pre-commit-ci-update-config branch October 28, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants