Python 3.7 support #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enable tests and declare support for Python 3.7 - Use `async` and `await` in all tests Note: this change may be blocked by pytest-dev#87. The behavior of the `ProcessPoolExecutor` tests is somewhat flaky in 3.7 and may cause the test suite to hang.
|
Per my note, https://travis-ci.org/pytest-dev/pytest-asyncio/jobs/401926629 is definitely hanging. |
Remove the `event_loop_process_pool` fixture and the `pytest.mark.asyncio_process_pool` marker to address deprecation and removal detailed in https://bugs.python.org/issue34075. Fixes pytest-dev#87.
|
Curious as to what the status is on this. Is there anything blocking that the community could chip in? |
|
Thank you very much @jonafato ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable tests and declare support for Python 3.7
Use
asyncandawaitin all testsRemove ProcessPoolExecutor support
Remove the
event_loop_process_poolfixture and thepytest.mark.asyncio_process_poolmarker to address deprecation andremoval detailed in https://bugs.python.org/issue34075.
Fixes #87.
Note: this change may be blocked by #87. The behavior of the
ProcessPoolExecutortests is somewhat flaky in 3.7 and may cause thetest suite to hang.
Because this change is blocked by #87, I've rolled the fix into this PR.
I can split this up if desired.