Skip to content

Stop using ProcessPoolExecutor as a default event loop executor #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jonafato opened this issue Jul 9, 2018 · 0 comments · Fixed by #88
Closed

Stop using ProcessPoolExecutor as a default event loop executor #87

jonafato opened this issue Jul 9, 2018 · 0 comments · Fixed by #88

Comments

@jonafato
Copy link
Contributor

jonafato commented Jul 9, 2018 •
edited
Loading

This usage is soon to be deprecated and prohibited by the standard library (https://bugs.python.org/issue34075), and it currently causes issues in 3.7.0 (https://bugs.python.org/issue34073). This issue was discovered when making changes in pytest-asyncio to make the tests work under 3.7.0. This affects the event_loop_process_pool fixture and the pytest.mark.asyncio_process_pool marker.
jonafato added a commit to jonafato/pytest-asyncio that referenced this issue Jul 9, 2018
@jonafato
Python 3.7 support
50337c8 
- Enable tests and declare support for Python 3.7
- Use `async` and `await` in all tests

Note: this change may be blocked by pytest-dev#87. The behavior of the
`ProcessPoolExecutor` tests is somewhat flaky in 3.7 and may cause the
test suite to hang.
@jonafato jonafato mentioned this issue Jul 9, 2018
Merged
jonafato added a commit to jonafato/pytest-asyncio that referenced this issue Jul 9, 2018
@jonafato
Remove ProcessPoolExecutor support
a21bb25 
Remove the `event_loop_process_pool` fixture and the
`pytest.mark.asyncio_process_pool` marker to address deprecation and
removal detailed in https://bugs.python.org/issue34075.

Fixes pytest-dev#87.
jonafato added a commit to jonafato/pytest-asyncio that referenced this issue Jul 9, 2018
@jonafato
Remove ProcessPoolExecutor support
d2dc635 
Remove the `event_loop_process_pool` fixture and the
`pytest.mark.asyncio_process_pool` marker to address deprecation and
removal detailed in https://bugs.python.org/issue34075.

Fixes pytest-dev#87.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Python 3.7 support jonafato/pytest-asyncio
1 participant
@jonafato