Remove development dependency on Docker #877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seifertm
changed the title
seifertm
changed the title
Removes the actionlint-docker pre-commit hook, which requires Docker to be set up on the development machine. Given that the pre-commit hooks already lint yaml files and that the GitHub actions are run for every PR, the Docker dependency seems unreasonable.
seifertm
force-pushed
the
remove-docker-dependency
branch
from
8a00b5d to
d335c25
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #877 +/- ##
=======================================
Coverage 92.08% 92.08%
=======================================
Files 2 2
Lines 480 480
Branches 96 96
=======================================
Hits 442 442
Misses 23 23
Partials 15 15 ☔ View full report in Codecov by Sentry. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the actionlint-docker pre-commit hook, which requires Docker to be set up on the development machine. Given that the pre-commit hooks already lint yaml files and that the GitHub actions are run for every PR, the Docker dependency seems unreasonable.
closes #595