Skip to content

Replace actionlint-docker pre-commit hook #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seifertm opened this issue Aug 11, 2023 · 0 comments · Fixed by #877
Closed

Replace actionlint-docker pre-commit hook #595

seifertm opened this issue Aug 11, 2023 · 0 comments · Fixed by #877

Comments

@seifertm
Copy link
Contributor

seifertm commented Aug 11, 2023

The actionlint-docker pre-commit hook requires users to have a working Docker setup, in order to make changes to pytest-asyncio.

  1. This prevents the linting from running as part of the CI.
  2. I don't think it's reasonable to require Docker in pre-commit hooks. If we want to have more contributors to the pytest-asyncio, the project setup should be as easy as possible.

However, I do believe that linting of GitHub actions files is a good thing to have. I suggest to find a dockerless alternative for the existing actionlint-docker hook. This would simplify the dev setup and enable GitHub action linting in the CI.

If there's no alternative available (not even yaml linting), I think that a complete removal of actionlint-docker should be considered.

@seifertm seifertm changed the title Remove actionlint-docker pre-commit hook Replace actionlint-docker pre-commit hook Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant