Skip to content

Updated docstrings for pymc.Beta #5500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2022
Merged

Conversation

sagartomar
Copy link
Contributor

@sagartomar sagartomar commented Feb 19, 2022

Thank your for opening a PR!

Depending on what your PR does, here are a few things you might want to address in the description:

For issue #5459

#DataUmbrellaPyMCSprint

Alternative mean (0 < mu < 1).
sigma: float
Alternative standard deviation (0 < sigma < sqrt(mu * (1 - mu))).
alpha : tensor_like of float
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alpha and beta are also optional I think, but I don't know what the defaults are @ricardoV94

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't specify alpha, beta then they will be calculated using mu, sigma. Does it make sense to write the equation for computing alpha, beta from mu, sigma in the docstrings or will that be too long?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the formula is already there in the extended summary (at the bottom)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it okay then to just change it to: alpha : tensor_like of float, optional or should we add something in the description saying that if not specifed then calculated from mu and sigma?

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #5500 (91ebd25) into main (9365663) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5500   +/-   ##
=======================================
  Coverage   81.51%   81.51%           
=======================================
  Files          81       81           
  Lines       14219    14219           
=======================================
  Hits        11591    11591           
  Misses       2628     2628           
Impacted Files Coverage Δ
pymc/distributions/continuous.py 97.23% <ø> (ø)

@OriolAbril OriolAbril merged commit 4dade6d into pymc-devs:main Feb 25, 2022
@sagartomar sagartomar deleted the beta_docstring branch March 11, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants