Make all MLDA tests deterministic #4313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4313 +/- ##
=======================================
Coverage 87.57% 87.57%
=======================================
Files 88 88
Lines 14274 14274
=======================================
Hits 12500 12500
Misses 1774 1774 |
twiecki
approved these changes
Dec 8, 2020
MarcoGorelli
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added
random_seedarguments to the sampler in three different MLDA tests intest_step.py, where they were missing.test_nonparallelized_chains_are_random,test_parallelized_chains_are_randomandtest_acceptance_rate_against_coarseness.This is a response to #4267
@MarcoGorelli mentioned that the issue seemed to be resolved after removing parallel testing, but here is a PR anyway, in case you want to merge these changes.