Skip to content

Rerun vi #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Rerun vi #373

wants to merge 2 commits into from

Conversation

ferrine
Copy link
Member

@ferrine ferrine commented Jun 9, 2022

related to #333

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ferrine
Copy link
Member Author

ferrine commented Jun 9, 2022

Read the Docs error is weird. So far I have some issues rerunning variational quick start due to mixtures refactoring

@drbenvincent
Copy link
Contributor

Hi @ferrine. Please remove all pymc.* and pymc3.* tags in the first code cells of all notebooks.

@drbenvincent
Copy link
Contributor

drbenvincent commented Jun 11, 2022

Just to be clear,

  • We are not converting pymc3 tags to pymc tags... we are removing all tags relating to pymc.* or pymc3.*
  • So it's not just the pymc3 that needs to be removed, but the entire tag. Eg. pymc3.Minibatch needs to disappear completely, not just the pymc3.

@ferrine
Copy link
Member Author

ferrine commented Jun 13, 2022

@drbenvincent got it, will fix

rerunning bayesian_neural_network_advi

rerunning bayesian_neural_network_advi

rerunning bayesian_neural_network_advi

rerunning bayesian_neural_network_advi

rerunning bayesian_neural_network_advi

rerunning bayesian_neural_network_advi

rerunning empirical approx

reorder imports

update the notebook

update the notebook

update minibatch example

rerun empirical approx

run pre commit

GLM rerun

update glm

remove references to pymc3

remove tags
@OriolAbril
Copy link
Member

I tried running the notebooks locally to see if it fixed the encoding issues in the docs build but some notebooks don't seem to run anymore with the latest release. Can someone else try to run them?

@fonnesbeck
Copy link
Member

fonnesbeck commented Jan 7, 2023

@ferrine do you want me to fix and finish this PR?

see #495

@fonnesbeck fonnesbeck mentioned this pull request Jan 10, 2023
3 tasks
@OriolAbril
Copy link
Member

superseeded by #497

@OriolAbril OriolAbril closed this Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants