Update VI quickstart and VI LDA notebooks #228
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
chiral-carbon
force-pushed
the
vi-nbs
branch
from
60a6a63 to
38dd425
Compare
chiral-carbon
force-pushed
the
vi-nbs
branch
from
e6935f5 to
b77492b
Compare
| } | ||
|
|
||
|
|
||
| @misc{sklearn2020topicextraction, |
There was a problem hiding this comment.
this entry is rendered a bit strangely right now, I think we should add an author like scikit-devs or something of the sort so the inline citation looks better. Or it might be also possible to use a custom text when citing, maybe with type cite:label I think it is (do check the docs please)
There was a problem hiding this comment.
does the rendered citation look better now?
| "* Rezende, D. J., & Mohamed, S. (2015). Variational inference with normalizing flows. arXiv preprint arXiv:1505.05770.\n", | ||
| "* Salimans, T., Kingma, D. P., & Welling, M. (2015). Markov chain Monte Carlo and variational inference: Bridging the gap. In International Conference on Machine Learning (pp. 1218-1226)." | ||
| "\n", | ||
| ":::{bibliography} :filter: docname in docnames\n", |
There was a problem hiding this comment.
the bibliography is not working. Is the filter think on the same line as the :::{bibliography}?
There was a problem hiding this comment.
yes it was, have changed it
|
View / edit / reply to this conversation on ReviewNB OriolAbril commented on 2021-10-13T04:53:38Z I would default to hiding this output with a toggleable: https://myst-nb.readthedocs.io/en/latest/use/hiding.html. |
|
View / edit / reply to this conversation on ReviewNB OriolAbril commented on 2021-10-13T04:53:39Z and make this a proper reference, see https://arviz-devs.github.io/arviz/contributing/developer_guide.html#hyperlinks. The complete import path is below, as it's quite long I would use |
|
View / edit / reply to this conversation on ReviewNB OriolAbril commented on 2021-10-13T04:53:40Z make minibatch a clickable reference, and hide output or even remove directly the cell below |
|
View / edit / reply to this conversation on ReviewNB Sayam753 commented on 2021-10-17T20:50:10Z Shouldn't the coords be - coords = {
"obs_id": np.arange(X_train.shape[0]),
"attr": np.arange(X_train.shape[1]),
"class": np.unique(y_train).shape[0],
}
?
|
|
View / edit / reply to this conversation on ReviewNB Sayam753 commented on 2021-10-17T20:50:11Z Line #1. coords = {"obs_id": data.shape[0], "col": data.shape[1]}
Same question here. Should |
|
Can you remove all |
|
Can someone take over? |
|
The LDA notebook should be deleted, it uses a not implement functionality. I do something similar in #373 |
|
I will delete it |
Addresses issues #135 and #137 and aims to advance it to Best Practices