CLN: Split into subpackages #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidastephens
force-pushed
the
one_file_per_datareader
branch
4 times, most recently
from
79c024e to
30dc86b
Compare
|
Personally I would prefer util or utils to common. But this is a big improvement overall. 👍 |
|
@hayd Agreed, this is a big improvement - thanks @femtotrader. I'll change to util.. Other than compatibility, data.py is redundant now. May be worth changing it to api.py and importing everything to the top level. |
davidastephens
force-pushed
the
one_file_per_datareader
branch
from
30dc86b to
d6e10a1
Compare
This was referenced Aug 23, 2015
Closed
Merged
Closed
|
The data.py is for backwards compat. The old API should remain available for a good while. Though there are other ways to get the same behaviour. IMO without a deprecation message. |
davidastephens
added a commit
that referenced
this pull request
Aug 23, 2015
CLN: Split into subpackages
|
I agree that importing |
|
I noticed that maybe But thanks for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@femtotrader @bashtage
Everyone fine with this version?
Fixes #58, replaces #68.