Skip to content

Deprecate data.py #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidastephens opened this issue Aug 23, 2015 · 2 comments
Closed

Deprecate data.py #71

davidastephens opened this issue Aug 23, 2015 · 2 comments

Comments

@davidastephens
Copy link
Member

Given the subpackage structure implemented by #69, data.py is really just the api, could move this to the top level so you could import directly from pandas-datareader.

ie:

instead of:

from pandas_datareader import data 
data.Options('aapl','yahoo')
import pandas_datareader as pdr
pdr.Options('aapl','yahoo')
@davidastephens davidastephens modified the milestones: 0.3.0, 0.5.0 Aug 23, 2015
@femtotrader
Copy link
Contributor

I won't deprecate for now but I would add right now to __init__.py this

from pandas_datareader.data import Options
from pandas_datareader.data import DataReader

so we will be able to do

import pandas_datareader as pdr
pdr.Options('aapl', 'yahoo')

but also

import pandas_datareader as pdr
pdr.DataReader('aapl', 'yahoo')

but with WorldBank we will still need

from pandas_datareader import wb

Kind regards

@jreback jreback removed this from the 0.5.0 milestone Jul 4, 2017
@bashtage
Copy link
Contributor

No real point in breaking tons of existing examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants