Update protobuf-javascript to support Protobuf 25.2

[eric-skydio]

This PR updates the code in protobuf-javascript to compile against the latest protobuf versions.

This primarily entails:

• Using absl:: methods instead of the previous vendored ones in Protobuf
• Explicitly using legacy descriptors when important properties are missing
• Explicitly deleting constructors rather than relying on the deleted GOOGLE_DISALLOW_EVIL_CONSTRUCTORS

[eric-skydio]

This could be required if you see errors like this after a protobuf upgrade:

In file included from external/protobuf_javascript/generator/protoc-gen-js.cc:33:0:
external/protobuf_javascript/generator/js_generator.h:39:10: fatal error: google/protobuf/stubs/logging.h: No such file or directory
 #include <google/protobuf/stubs/logging.h>
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

[dibenede]

What are the legacy descriptors needed for? I haven't seen them used before and the inclusion the descriptor_legacy.h seems to be causing a build issue.

[eric-skydio]

I think that field->file()->syntax() is deprecated and no longer available in the FileDescriptor class. Using FileDescriptorLegacy seemed like the easiest and lowest-risk fix since I'm not entirely sure what this is actually trying to check. Similar concerns showed up a couple other places.

[eric-skydio]

It looks like the first version of this failed because I didn't actually update the bzlmod dependency, so CI was building against an old version of protobuf. This didn't come up in my local testing since our repo pulls in newer protobuf through other mechanisms.

[eric-skydio]

Note that 23.1 is the latest available through bzlmod, but this is tested to also work with 25.x on our internal system.

[luangong]

You can use a specific version of the module even if it’s not yet published to BCR with git_override, like this:

bazel_dep(name = "protobuf", version = "25.3", repo_name = "com_google_protobuf")

git_override(
    module_name = "protobuf",
    remote = "https://github.com/protocolbuffers/protobuf.git",
    # https://github.com/protocolbuffers/protobuf/releases/tag/v25.3
    commit = "4a2aef570deb2bfb8927426558701e8bfc26f2a4",
)

or with archive_override, like this:

bazel_dep(name = "protobuf", version = "25.3", repo_name = "com_google_protobuf")

archive_override(
    module_name = "protobuf",
    urls = ["https://github.com/protocolbuffers/protobuf/releases/download/v25.3/protobuf-25.3.tar.gz"],
    integrity = "sha256-0ZZD0mW5eDgzUrMUPwTAZB7qdadSNcERzAGhNQFzGA4=",
    strip_prefix = "protobuf-25.3",
)