(minor) fix indentation in toObject function

eric-skydio · eric-skydio · commit c1bb25e41202 · 2024-04-18T17:00:11.000-07:00
This fixes a very minor aesthetic regression associated with newer protobuf versions protocolbuffers#196 Apparently the behavior of printer->Print has changed subtly in how it strips leading spaces.
diff --git a/generator/js_generator.cc b/generator/js_generator.cc
@@ -2216,10 +2216,11 @@ void Generator::GenerateClassToObject(const GeneratorOptions& options,
       continue;
     }
 
+    auto indent = printer->WithIndent(4);
     if (!first) {
-      printer->Print(",\n    ");
+      printer->Emit(",\n");
     } else {
-      printer->Print("\n    ");
+      printer->Emit("\n");
       first = false;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -2216,10 +2216,11 @@ void Generator::GenerateClassToObject(const GeneratorOptions& options,`
`2216`	`2216`	`continue;`
`2217`	`2217`	`}`
`2218`	`2218`
	`2219`	`+ auto indent = printer->WithIndent(4);`
`2219`	`2220`	`if (!first) {`
`2220`		`- printer->Print(",\n ");`
	`2221`	`+ printer->Emit(",\n");`
`2221`	`2222`	`} else {`
`2222`		`- printer->Print("\n ");`
	`2223`	`+ printer->Emit("\n");`
`2223`	`2224`	`first = false;`
`2224`	`2225`	`}`
`2225`	`2226`