Keep dependency versions in sync for WORKSPACE and MODULE.bazel
#194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in the Bazel blog article, the old `WORKSPACE` system is planned to be disabled by default in Bazel 8, and to be removed altogether in Bazel 9. The `WORKSPACE` file will eventually be removed, but for now, it’s best to keep the dependency versions in both systems in sync, so that we can build the project with Bzlmod either disabled or enabled. Note that there is a compatibility issue that prevents this project from depending on protobuf v22 and higher. Until that issue is fixed, v21.7 is the highest version that both systems have. References: - https://blog.bazel.build/2023/12/11/bazel-7-release.html#bzlmod - https://registry.bazel.build/modules/protobuf - https://github.com/protocolbuffers/protobuf/blob/v21.7/protobuf_deps.bzl#L96-L104 - #186
|
Could you please also change these to 21.7 for consistency? |
dibenede
approved these changes
Mar 12, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the Bazel blog article, the old
WORKSPACEsystem is planned to be disabled by default in Bazel 8, and to be removed altogether in Bazel 9. TheWORKSPACEfile will eventually be removed, but for now, it’s best to keep the dependency versions in both systems in sync, so that we can build the project with Bzlmod either disabled or enabled.Note that there is a compatibility issue that prevents this project from depending on protobuf v22 and higher. Until that issue is fixed, v21.7 is the highest version that works with both systems.
References: