Use bzlmod to manage external dependencies #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bzlmod is the new way to to manage external dependencies. The `--enable_bzlmod` flag was introduced in Bazel 6 and has been turned on by default since Bazel 7, so declaring external dependencies in `WORKSPACE` is considered leagcy behavior. The old `WORKSPACE`-system is planned to be disabled in Bazel 8 and to be removed altogether in Bazel 9. This commit migrates from `WORKSPACE` to bzlmod. References: - https://bazel.build/external/overview - https://bazel.build/external/migration - https://blog.bazel.build/2023/12/11/bazel-7-release.html#bzlmod
dibenede
requested changes
Jan 31, 2024
There was a problem hiding this comment.
Apologies for the delay; I've been trying to dig into our policies on some things.
I have no major objection to accepting this change. However, could you please remove the lock file? While we should add one, it's too large to meaningfully review.
I'm thinking it would be easier for us to just generate it ourselves per https://bazel.build/external/lockfile.
|
The lockfile is already auto-generated. Maybe we should enable |
dibenede
approved these changes
Feb 1, 2024
|
I think it'll be ok for the time being. Thank you the contribution! |
This was referenced Mar 12, 2024
dibenede
pushed a commit
that referenced
this pull request
Mar 12, 2024
…194) * Keep dependency versions in sync for WORKSPACE and MODULE.bazel As mentioned in the Bazel blog article, the old `WORKSPACE` system is planned to be disabled by default in Bazel 8, and to be removed altogether in Bazel 9. The `WORKSPACE` file will eventually be removed, but for now, it’s best to keep the dependency versions in both systems in sync, so that we can build the project with Bzlmod either disabled or enabled. Note that there is a compatibility issue that prevents this project from depending on protobuf v22 and higher. Until that issue is fixed, v21.7 is the highest version that both systems have. References: - https://blog.bazel.build/2023/12/11/bazel-7-release.html#bzlmod - https://registry.bazel.build/modules/protobuf - https://github.com/protocolbuffers/protobuf/blob/v21.7/protobuf_deps.bzl#L96-L104 - #186 * Update PROTOC_VERSION to 21.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bzlmod is the new way to to manage external dependencies. The
--enable_bzlmodflag was introduced in Bazel 6 and has been turned on by default since Bazel 7, so declaring external dependencies inWORKSPACEis considered legacy behavior. The oldWORKSPACE-system is planned to be disabled in Bazel 8 and to be removed altogether in Bazel 9.This commit migrates from
WORKSPACEto bzlmod.References: