Skip to content

Use tini as a minimal init for the docker image #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

noushi
Copy link
Contributor

@noushi noushi commented Jul 20, 2016

This PR fixes #12 (so far).

It's based on alpine:3.4 to minimize image size.

Please notice that I only modified the docker make target, docker-build will need to be modified as well.

@wrouesnel
Copy link
Contributor

So I don't know what to do about this one because it's an issue I can't replicate anywhere else.

@noushi
Copy link
Contributor Author

noushi commented Aug 2, 2016

Aside from the bug we experienced and solved using this PR, it's better to have both:

  • a Linux environment one can use to enter a running container
  • signal handling using an init-compatible entrypoint

Basically you have two ways of managing signals:

  • you use an init-compatible entrypoint
  • you handle the signals yourself in your entrypoint (postgres_exporter in our case)

That said, although Prometheus (server) handles signals itself (as shown here and here), it still uses a minimal base image, with regular Linux tools, like sh, ps, cat...

If not for the bug fix, this PR serves as two feature enhancements:

  • signal handling
  • OS environment in image

@wrouesnel
Copy link
Contributor

So I'm going to close this for now, as the underlying issue I haven't been able to replicate. Closes #12 as well.

My preferred fix for this is to handle the correct signals in the postgres_exporter binary, which as far as I know does happen at the moment (in the sense that I have not been able to replicate the issue locally).

@wrouesnel wrouesnel closed this Sep 8, 2016
@noushi
Copy link
Contributor Author

noushi commented Sep 9, 2016

Sure, thank you @wrouesnel .

dehaansa pushed a commit to dehaansa/postgres_exporter that referenced this pull request Oct 24, 2024
* lint fixes

* Add .lint exclusion file - for mixtool

* Update .lint exclusion file - for mixtool
Sticksman pushed a commit to Sticksman/postgres_exporter that referenced this pull request Apr 24, 2025
…e-name-for-preferences-cluster

Adds the database name in the DSN for preference clusters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Huge number of open file descriptors after days of running
2 participants