Skip to content

Commit c3c063d

Browse files
authored
Mixin Lint fixes (prometheus-community#14)
* lint fixes * Add .lint exclusion file - for mixtool * Update .lint exclusion file - for mixtool
1 parent 8c34fa8 commit c3c063d

File tree

2 files changed

+18
-3
lines changed

2 files changed

+18
-3
lines changed

postgres_mixin/.lint

+15
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
---
2+
exclusions:
3+
panel-units-rule:
4+
reason: Ignoring so far, need to address this in future
5+
panel-title-description-rule:
6+
reason: Ignoring so far, need to address this in future
7+
panel-datasource-rule:
8+
reason: "Loki datasource variable is being named as loki_datasource now while linter expects 'datasource'"
9+
template-datasource-rule:
10+
reason: "Based on new convention we are using variable names prometheus_datasource and loki_datasource where as linter expects 'datasource'"
11+
alert-name-camelcase:
12+
reason: QPS is a common acronym (Queries Per Second) and should be allowed
13+
entries:
14+
- alert: PostgreSQLQPS
15+

postgres_mixin/dashboards/postgres-overview.libsonnet

+3-3
Original file line numberDiff line numberDiff line change
@@ -1338,7 +1338,7 @@
13381338
"query": "label_values(pg_up, job)",
13391339
"refId": "StandardVariableQuery"
13401340
},
1341-
"refresh": 1,
1341+
"refresh": 2,
13421342
"regex": "",
13431343
"skipUrlSync": false,
13441344
"sort": 0,
@@ -1372,7 +1372,7 @@
13721372
"query": "label_values(pg_up{job=~\"$job\"},instance)",
13731373
"refId": "StandardVariableQuery"
13741374
},
1375-
"refresh": 1,
1375+
"refresh": 2,
13761376
"regex": "",
13771377
"skipUrlSync": false,
13781378
"sort": 0,
@@ -1397,7 +1397,7 @@
13971397
"query": "label_values(pg_stat_database_tup_fetched{%(postgresExporterSelector)s,datname!~\"template.*|postgres\"},datname)" % $._config,
13981398
"refId": "StandardVariableQuery"
13991399
},
1400-
"refresh": 1,
1400+
"refresh": 2,
14011401
"regex": "",
14021402
"skipUrlSync": false,
14031403
"sort": 0,

0 commit comments

Comments
 (0)