-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
choropleth improvements #947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ready for a review when tests pass Perhaps this should also be version 2.5.0 Chelsea? |
💃 from me |
@Kully I don't think the package data should be added in the test directory: https://github.com/plotly/plotly.py/tree/master/plotly/tests/test_optional/test_figure_factory don't you want to be testing that the package data is read properly from: https://github.com/plotly/plotly.py/tree/master/plotly/package_data ? |
re: #947 (comment) |
💃 |
addresses: #944
Also does:
offline_mode
param from ff.create_choropleth #944