Skip to content

rename offline_mode param from ff.create_choropleth #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kully opened this issue Feb 21, 2018 · 4 comments
Closed

rename offline_mode param from ff.create_choropleth #944

Kully opened this issue Feb 21, 2018 · 4 comments
Assignees

Comments

@Kully
Copy link
Contributor

Kully commented Feb 21, 2018

Enabling offline_mode modifies the centroid points that are plotted in a choropleth to include the parameters selected and unselected which change the visibility of these points upon dragbox hover. This feature did not exist before merging the choropleth figure factory, meaning these keys could only pass with a plotly fig if: 1) offline mode and 2) validate=False

Now these keys are part of the plotly reference:
https://plot.ly/python/reference/#scatter-selected
https://plot.ly/python/reference/#scatter-unselected

I vote for removing this param completely,

@Kully Kully self-assigned this Feb 21, 2018
@Kully Kully changed the title rename offline_mode param in ff.create_choropleth remove offline_mode param from ff.create_choropleth Feb 21, 2018
@cldougl
Copy link
Member

cldougl commented Feb 21, 2018

+1

@Kully
Copy link
Contributor Author

Kully commented Feb 21, 2018

After inspection of the code, it makes more sense to rename the variable.

@Kully Kully changed the title remove offline_mode param from ff.create_choropleth rename offline_mode param from ff.create_choropleth Feb 21, 2018
@Kully Kully mentioned this issue Feb 28, 2018
4 tasks
@jonmmease
Copy link
Contributor

@Kully , can we close this, or is there anything more to do here?

@Kully
Copy link
Contributor Author

Kully commented Sep 23, 2018

@Kully , can we close this, or is there anything more to do here?

Yes we can closed. Already addressed.

@Kully Kully closed this as completed Sep 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants