-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
rename offline_mode
param from ff.create_choropleth
#944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
offline_mode
param in ff.create_choroplethoffline_mode
param from ff.create_choropleth
+1 |
After inspection of the code, it makes more sense to rename the variable. |
offline_mode
param from ff.create_choroplethoffline_mode
param from ff.create_choropleth
@Kully , can we close this, or is there anything more to do here? |
Yes we can closed. Already addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Enabling
offline_mode
modifies the centroid points that are plotted in a choropleth to include the parametersselected
andunselected
which change the visibility of these points upon dragbox hover. This feature did not exist before merging the choropleth figure factory, meaning these keys could only pass with a plotly fig if: 1) offline mode and 2) validate=FalseNow these keys are part of the plotly reference:
https://plot.ly/python/reference/#scatter-selected
https://plot.ly/python/reference/#scatter-unselected
I vote for removing this param completely,
The text was updated successfully, but these errors were encountered: