Make temporary fix to plotly.min.js so that it loads in offline module #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- browserify/webworkify#29 - offline was broken in plotly.py 1.12.6 where plotly.js was updated to 1.16.4
|
tested! 💃 |
|
@etpinard do you mind bumping the version # here too so I can update the package on pip w/ this fix |
etpinard
added a commit
to plotly/plotly.js
that referenced
this pull request
Sep 7, 2016
- which is basically what plotly/plotly.py#545 implemented - see browserify/webworkify#29 for more info
|
hey mine still won't work and i don't undertand how you fix it so easily please help @ etpinard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As first discovered in this forum post,
offlineis broken ever since #538 where plotly.js got bumped to from the1.14.xseries to the1.16.2.More precisely,
init_notebook_mode()(with the defaultconnected=False) fails to load plotly.js as a require.js module. From my observations, the CDN link (withconnected=True) appears to load fine.Something is up with a
mapbox-gldependency calledwebworkifyin a minified bundle. See browserify/webworkify#29 for more info. Ideally, this issue should be fixed upstream.But for now, I propose a uber hacky fix where I manually fix the minified bundle.
For those interested in non-nonsensical JS drama, I had to replace
by
to get
offlineworking again.