Test plotly.min.js in Require.js environment #914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- which basically mimics how plotly.js is injected into Jupyter NB by plotly.py
- which is basically what plotly/plotly.py#545 implemented - see browserify/webworkify#29 for more info
| @@ -52,6 +53,16 @@ function makeTestImageFolders() { | |||
| makeOne(constants.pathToTestImagesDiff, 'test image diff folder'); | |||
| } | |||
|
|
|||
| // Make script file that define plotly in a RequireJS context | |||
| function makeRequireJSFixture() { | |||
| var bundle = fs.readFileSync(constants.pathToPlotlyDistMin, 'utf-8'), | |||
There was a problem hiding this comment.
Important I chose to test Require.js import with the dist/plotly.min.js bundle only.
That means that Require.js will only be tested on npm version commits (when the dist/ is updated).
Main reason for this shotcut: minifying the full plotly.js bundle take about 1 minute on CI.
|
Yes this is pretty unfortunate but at least you found a way to test it! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is unfortunately necessary to make sure that
plotly.min.jscan be loaded inside a Jupyter notebook by https://github.com/plotly/plotly.pySee:
for more info.
In brief, this PR:
plotly.min.jsloads correctly via Require.js.replaceto fix the aforementioned issue.