Skip to content

fix: pandas DataFrame with non-default Index was resulting in scrambled data in scatter_matrix #4921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

MarcoGorelli
Copy link
Contributor

@MarcoGorelli MarcoGorelli commented Dec 1, 2024

These issue get closed "for free" with the latest Narwhals release, as a result of narwhals-dev/narwhals#1474 having been addressed:

Furthermore, it allows for the Plotly codebase to be simplified a bit, as maybe_reset_index isn't necessary any more. So, I've:

  • made that simplification
  • bumped the minimum Narwhals
  • added a test to check this stays fixed

Demo:

Latest stable plotly release:

image

This branch:

image

@MarcoGorelli MarcoGorelli marked this pull request as ready for review December 1, 2024 11:49
@gvwilson gvwilson requested a review from emilykl December 1, 2024 22:33
@gvwilson gvwilson added community community contribution fix fixes something broken labels Dec 1, 2024
Copy link
Contributor

@emilykl emilykl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, @MarcoGorelli. Sorry for the delayed review, I wanted to take the time to make sure I understood the differences between the Pandas and Narwhals index behavior. Looks good! 🚀

@emilykl emilykl merged commit a5e628c into plotly:master Dec 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment